Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core-client] Version to 1.4.0 #18780

Merged
merged 2 commits into from
Nov 23, 2021

Conversation

sadasant
Copy link
Contributor

@sadasant sadasant commented Nov 22, 2021

What if we release @azure/core-client 1.3.3 tomorrow? 🙂
Changed this PR to upgrade the version of core-client to 1.4.0 since CAE support is a new thing entirely, not a patch to something already in this package.

@ramya-rao-a
Copy link
Contributor

ramya-rao-a commented Nov 22, 2021

What if we release @azure/core-client 1.3.3 tomorrow

There is not enough reason to do an out of band release 2 days before the holidays.
If this is about #18776, then I have a recommendation in #18776 (comment)

I would instead recommend using this PR to update the package version to 1.4.0
Since CAE was a new feature that was added, the next release should have a minor version update, not patch

@sadasant
Copy link
Contributor Author

@ramya-rao-a can do!

@sadasant sadasant changed the title [core-client] Release date [core-client] Version to 1.4.0 Nov 22, 2021
@sadasant
Copy link
Contributor Author

@ramya-rao-a done!

@sadasant sadasant enabled auto-merge (squash) November 22, 2021 23:59
@sadasant sadasant merged commit 74dbf07 into Azure:main Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants